Mirrors
/
protobuf
mirror of https://github.com/protocolbuffers/protobuf.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add no-op support for the experimental_strip_nonfunctional_codegen parameter. 

This will be used for codegen tests to verify that an editions upgrade hasn't changed anything meaningful.

PiperOrigin-RevId: 608660846
pull/15876/head
Mike Kruskal 2024-02-20 10:42:35 -08:00 committed by Copybara-Service
parent 038007e748
commit e26193d168
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
upb_generator/protoc-gen-upb.cc
View File

@ -1106,6 +1106,8 @@ bool ParseOptions(Plugin* plugin, Options* options) {
for (const auto& pair : ParseGeneratorParameter(plugin->parameter())) {
if (pair.first == "bootstrap_upb") {
options->bootstrap = true;
} else if (pair.first == "experimental_strip_nonfunctional_codegen") {
continue;
} else {
plugin->SetError(absl::Substitute("Unknown parameter: $0", pair.first));
return false;

11
upb_generator/protoc-gen-upb_minitable-main.cc
View File

@ -42,10 +42,13 @@ void GenerateFile(const DefPoolPair& pools, upb::FileDefPtr file,
}
bool ParseOptions(Plugin* plugin) {
const auto param = ParseGeneratorParameter(plugin->parameter());
if (!param.empty()) {
plugin->SetError(absl::Substitute("Unknown parameter: $0", param[0].first));
return false;
for (const auto& pair : ParseGeneratorParameter(plugin->parameter())) {
if (pair.first == "experimental_strip_nonfunctional_codegen") {
continue;
} else {
plugin->SetError(absl::Substitute("Unknown parameter: $0", pair.first));
return false;
}
}
return true;