mirror of https://github.com/NetBSD/src.git
ad49149131
1. For tools that use elftoolchain: always use elftoolchain's elfdefinitions.h. Don't even think about looking at the host's sys/exec_elf.h, which makes no sense and should never happen. (ELF tools that don't use elftoolchain, like m68k-elf2coff, continue to use nbincludes/sys/exec_elf.h. But no more nbincludes hacks in elftoolchain.) 2. For kernel components (solaris, zfs, dtrace): always use sys/exec_elf.h, even in Solaris components via sys/elf.h. elfdefinitions.h is not wired up in the kernel build at all. 3. For most userland components that involve libelf: use elfdefinitions.h via libelf header files (libelf.h, gelf.h). libdtrace in particular requires _all_ R_* reloc type definitions, but sys/exec_elf.h brings in only the _current machine's_ R_* reloc type definitions. (While here: Use uintptr_t instead of Elf_Addr for pointer-to-integer cast, since Elf_Addr is MD and provided only by sys/exec_elf.h, not by elfdefinitions.h.) And most userland components using libelf don't rely on any properties of the current machine from sys/exec_elf.h, so they can use libelf's elfdefinition.h. Exceptions: - dtrace drti.c relies on link.h -> link_elf.h -> sys/exec_elf.h, but it also relies on sys/dtrace.h -> sys/elf.h -> elfdefinitions.h like other userland components using sys/elf.h. - kdump-ioctl.c uses sys/exec_elf.h directly and sys/dtrace.h -> sys/elf.h -> elfdefinitions like other userland components using sys/elf.h. - t_ptrace_wait.c (via t_ptrace_core_wait.h) uses libelf to parse core files, but relies on sys/exec_elf.h for struct netbsd_elfcore_procinfo. None of these exceptions needs all R_* reloc type definitions, so as a workaround, we can just suppress libelf's elfdefinitions.h by defining _SYS_ELFDEFINITIONS_H_ and use sys/exec_elf.h in these exceptions. And undo the whole BUILTIN_ELF_HEADERS mistake. This was: - half bogus workarounds for missing build_install dependencies in tools/Makefile, which are no longer missing now, and - half futile attempt to use src/sys/sys/exec_elf.h via nbincludes in tools involving libelf instead of libelf's elfdefinitions.h, which collides. Longer-term, we may wish to unify sys/exec_elf.h and libelf's elfdefinitions.h, so we don't have to play these games. But at least now the games are limited to three .c files (one of which is generated by Makefile.ioctl-c), rather than haphazardly applied tree-wide by monstrous kludges in widely used .h files with broken hackarounds to get the tools build lurching to completion. |
||
---|---|---|
.. | ||
amiga-elf2bb | ||
amiga-txlt | ||
arm-elf2aout | ||
asn1_compile | ||
autoconf | ||
awk | ||
binstall | ||
binutils | ||
cap_mkdb | ||
cat | ||
cksum | ||
compat | ||
compile_et | ||
config | ||
crunchgen | ||
ctags | ||
ctfconvert | ||
ctfmerge | ||
cvslatest | ||
date | ||
db | ||
dbsym | ||
disklabel | ||
dtc | ||
elftoolchain | ||
elftosb | ||
fdisk | ||
fgen | ||
file | ||
gcc | ||
gdb | ||
genassym | ||
gencat | ||
gettext | ||
gmake | ||
gmp | ||
gpt | ||
grep | ||
groff | ||
gzip | ||
hexdump | ||
host-mkdep | ||
hp300-mkboot | ||
hppa-mkboot | ||
ibmnws-ncdcs | ||
installboot | ||
isl | ||
join | ||
lex | ||
libctf | ||
libfdt | ||
libprop | ||
lint | ||
lint1 | ||
lint2 | ||
llvm | ||
llvm-clang | ||
llvm-clang-tblgen | ||
llvm-include | ||
llvm-lib | ||
llvm-tblgen | ||
lorder | ||
m4 | ||
m68k-elf2aout | ||
macppc-fixcoff | ||
make | ||
makefs | ||
makekeys | ||
makestrs | ||
makewhatis | ||
mandoc | ||
mdsetimage | ||
menuc | ||
mips-elf2ecoff | ||
mkcsmapper | ||
mkdep | ||
mkesdb | ||
mklocale | ||
mknod | ||
mktemp | ||
mkubootimage | ||
mpc | ||
mpfr | ||
msgc | ||
mtree | ||
mvme68k-wrtvid | ||
nbperf | ||
pax | ||
paxctl | ||
pcc | ||
pigz | ||
pkg_install | ||
powerpc-mkbootimage | ||
pwd_mkdb | ||
rpcgen | ||
sed | ||
sgivol | ||
slc | ||
sortinfo | ||
sparkcrc | ||
stat | ||
strfile | ||
sunlabel | ||
texinfo | ||
tic | ||
tsort | ||
uudecode | ||
veriexecgen | ||
vgrind | ||
xz-bin | ||
xz-include | ||
xz-lib | ||
yacc | ||
zic | ||
Makefile | ||
Makefile.gmakehost | ||
Makefile.gnuhost | ||
Makefile.gnuwrap | ||
Makefile.host | ||
Makefile.nbincludes | ||
README | ||
headerlist | ||
mkheaderlist.sh |
README
$NetBSD: README,v 1.5 2022/02/03 20:32:38 rillig Exp $ Notes for NetBSD src/tools Background ========== Several programs that are part of NetBSD are also built as tools. Such programs are typically built twice: once as a tool and once as part of the release build. Tools are relevant only when the make(1) variable USETOOLS=yes, which is the default for most NetBSD builds. Tools are built on the host platform, using the host compiler, and will run on the host platform during the cross-build of the remainder of NetBSD. They are built near the beginning of a NetBSD build (e.g. "build.sh tools" or "make tools" from the top level src directory), and installed in ${TOOLDIR}. Tools are executed during the main part of the build, when several TOOL_* variables defined in src/share/mk/bsd.*.mk will refer to the tools installed in ${TOOLDIR}. Portability =========== Programs that are built as tools need to be more portable than other parts of NetBSD, because they will need to run on the host platform. Most tools should restrict themselves to C language features that are defined in C99 (ISO/IEC 9899-1999); they should avoid using C11 language features, such as <threads.h>, _Alignof, <uchar.h>, _Generic, static_assert, anonymous structures and unions. Tools may use library features such as functions, macros, and types, that are defined in C99 and in POSIX (IEEE Std 1003.1) (XXX year?), and features that are provided by the compatibility framework (src/tools/compat) described in a separate section below. If a tool attempts to use a feature that is not available on the host platform, then the tools build will fail. This can be addressed by changing the tool to avoid that feature, or by adding the feature to the src/tools/compat framework. It is usually easy to add new macros or functions to src/tools/compat, and that is usually better than adding compatibility definitions to individual tools. Compatibility framework ======================= src/tools/compat provides a compatibility framework for use by tools. It installs the following components, and more: ${TOOLDIR}/lib/libnbcompat.a A library containing functions that are needed by some tools. ${TOOLDIR}/include/nbtool_compat.h A header file defining macros that are needed by some tools. ${TOOLDIR}/share/compat/defs.mk A makefile fragment, to be included by other makefiles, to define make variables appropriate for building tools. Among other things, this makefile fragment automatically adds the libnbcompat.a library to the LDADD and DPADD variables, so that tools will be linked with that library, and adds -I${NETBSDSRCDIR}/tools/compat and -DHAVE_NBTOOL_CONFIG_H=1 to the HOST_CPPFLAGS variable, so that compiled programs can detect when they are being built as tools. Adapting Makefiles for use with tools ===================================== Makefiles under src/tools/*/Makefile should define the HOSTPROG variable. This is typically done by tools/Makefile.hostprog, which is directly or indirectly included by all Makefiles in src/tools/*/Makefile. Makefiles in the non-tools part of the src tree can test whether or not the HOSTPROG variable is defined, in order tell the difference between building a tool and building part of a NetBSD release, and they may alter their behavior accordingly. For example, the Makefile may conditionally refrain from compiling and linking certain files, and the Makefile may conditionally pass macros to the compiler via constructs like this: .if defined(HOSTPROG) CPPFLAGS+= -DWITH_FEATURE_X=0 # exclude feature X from tools build .else CPPFLAGS+= -DWITH_FEATURE_X=1 # include feature X in release build .endif Adapting Programs for use with tools ==================================== When a tool is being built, the C compiler should automatically be invoked with -DHAVE_NBTOOL_CONFIG_H=1. This is done as a result of settings in ${TOOLDIR}/share/compat/defs.mk, which should be included from src/tools/Makefile.host, which should be included directly or indirectly from src/tools/*/Makefile. A C source file can test whether the HAVE_NBTOOL_CONFIG_H macro is defined, in order to tell whether or not it is being compiled as part of a tool. In order to obtain the definitions provided by the tools compatibility framework, almost every C source file that is built as part of a tool should have lines like these as the first non-comment lines: #if HAVE_NBTOOL_CONFIG_H #include "nbtool_config.h" #endif To omit features from the tools version of a program, the program may test the HAVE_NBTOOL_CONFIG_H macro, like this: #if HAVE_NBTOOL_CONFIG_H ... code to be used when built as a tool #else ... code to be used when built as part of a release #endif It is often preferable to use macros whose names refer to the features that should be included or omitted. See the section on "Adapting Makefiles for use with tools" for an example in which the Makefile passes -DWITH_FEATURE_X=0 or -DWITH_FEATURE_X=1 to the compiler according to whether or not the program is being built as a tool. Then the program can use code like this: #if WITH_FEATURE_X ... code to be used when FEATURE X is desired, ... e.g. when being built as part of a release. #else ... code to be used when FEATURE X is not desired, ... e.g. when being built as a tool. #endif